Add extensible log handler #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject directory and send to stdout/stderr in cli. Add tests for log module.
bboynton97
reviewed
Dec 22, 2024
Contributor
|
@tcdent i merged in telemetry and consolidated |
bboynton97
approved these changes
Dec 22, 2024
Collaborator
Author
|
@bboynton97 wanted to make sure this was working functionally before we pulled the trigger on merge. I honestly havent't used the CLI enough with this enabled to know that everything we were printing before is displaying correctly. will spend more time with it this week; hopefully you can, too |
…ors. Utilize logging levels for messaging.
Improved general text inputs with validations. Simplified code.
Refactored subprocess.run to be cross-platform compatible. Fixed failing tests on win32.
…was the same across all tests
This prevents us from overriding existing values in the user's env with placeholder values.
…s imported and called instead of running main as a module)
tcdent
commented
Dec 31, 2024
tcdent
commented
Dec 31, 2024
…er. Improve cleanliness of messaging.
…-initializing a project directory befor einit has run, and also saves us from littering agentstack.log files outside of project directories.
bboynton97
approved these changes
Jan 10, 2025
Contributor
|
beautiful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect logs to a file in the user's project directory and send to stdout/stderr in cli.
Add tests for log module.
This addresses #151