Load .env first and favor it over system vars #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @caike! thank you for your contribution! this is a great addition, i think the one thing we need to make this work though, is to add variables to If you can make that change, @tcdent or I can merge this PR! |
This avoids overriding any predefined ENVs the user may already have set in their system.
caike
force-pushed
the
load-envs-before-agentops
branch
from
d3c31a7 to
4991922
Compare
bboynton97
reviewed
Dec 7, 2024
| We don't want to override values the user may already have set | ||
| in their environment variables so we add a new line commented out. | ||
| """ | ||
| f.write(f"\n# {key}={value}") |
bboynton97
approved these changes
Dec 7, 2024
Collaborator
Author
Right on, that does make sense 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
Fixes #98
📘 Description
Not sure if this is the most elegant solution but it fixes an issue where the template environment variable values "
..." would persist and cause an error onagenstack rundue toClientnot being populated with the proper values defined in.envsuch as AGENTOPS_API_KEY.Loading the envs before loading the module and favoring
.envover system vars (which I suspect should be the recommended behavior: local config > system config) ensures thatClientis properly configured with values from.env🧪 Testing
The
agentstack runcommand is able to successfully connect to my AgentOps account using the API key found on.env