Enforce plugin registration in root webcmd-plugin.json - #301
Closed
ayushsingh82 wants to merge 1 commit into
Closed
Conversation
…#222) The webcmd-adapter-author skill documents adding a promoted plugin to the root webcmd-plugin.json plugins map, but nothing checks it landed. webcmd plugin create, webcmd plugin install, and webcmd validate <site> all succeed even when that step is skipped, so the gap goes unnoticed until the plugin is silently missing from the catalog. - webcmd validate (no target) now warns when a plugins/<site> directory has its own webcmd-plugin.json but isn't registered in the root manifest's plugins map. - adapter-template.md gets an explicit grep-based verification step right after the root-manifest edit.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. This review is advisory and does not block merging. |
Contributor
|
Thanks for the thorough implementation and tests. I’m closing this because it enforces a workflow that is no longer intended: the root plugin catalog and README table are generated after merge from each plugin’s local manifest by the community-plugin sync workflow. A validation warning here would incorrectly flag contributions that follow the current generated-catalog process. #117 will align the authoring documentation with that workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webcmd-adapter-authorskill's promotion flow could be silently skipped:webcmd plugin create,webcmd plugin install, andwebcmd validate <site>all succeed even when a promoted plugin never lands in the rootwebcmd-plugin.json.webcmd validate(untargeted) now warns when aplugins/<site>directory has its ownwebcmd-plugin.jsonbut is missing from the root manifest'spluginsmap, via a newfindUnregisteredPlugins()inplugin-manifest.ts. No-op outside a monorepo checkout (e.g. npm installs, which ship neitherplugins/nor a root manifest).adapter-template.mdgets an explicit grep-based verification step right after the root-manifest edit, so an agent following the skill has to confirm the step landed instead of trusting that every command succeeding means it worked.Test plan
npx vitest run src/plugin-manifest.test.ts src/validate.test.ts— new coverage forfindUnregisteredPlugins(missing/registered/disabled/no-monorepo/no-plugins/-dir cases) and thewebcmd validatewiringnpx tsc --build --force— cleanamazon's entry from the root manifest, confirmedwebcmd validateflagged it, restored and confirmed clean againunitvitest project (147 files / 2356 tests) passes with these changes in the tree