Skip to content

fix: scroll to runtime-added highlight (Issue #257) #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnphilipp wants to merge 2 commits into from
Closed

fix: scroll to runtime-added highlight (Issue #257) #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9559033
fix scrolling to runtime-added highlight
johnphilipp Jun 24, 2025
6be4dd8
memoize getHighlightById and adjust deps to satisfy useExhaustiveDepe…
johnphilipp Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions example/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,15 @@ export function App() {

const scrollViewerTo = useRef((highlight: IHighlight) => {});

const getHighlightById = useCallback(
(id: string) => highlights.find((h) => h.id === id),
[highlights],
);

const scrollToHighlightFromHash = useCallback(() => {
const highlight = getHighlightById(parseIdFromHash());
if (highlight) {
scrollViewerTo.current(highlight);
}
}, []);
if (highlight) scrollViewerTo.current(highlight);
}, [getHighlightById]);

useEffect(() => {
window.addEventListener("hashchange", scrollToHighlightFromHash, false);
Expand All @@ -87,10 +90,6 @@ export function App() {
};
}, [scrollToHighlightFromHash]);

const getHighlightById = (id: string) => {
return highlights.find((highlight) => highlight.id === id);
};

const addHighlight = (highlight: NewHighlight) => {
console.log("Saving highlight", highlight);
setHighlights((prevHighlights) => [
Expand Down