fix: Recover prompt loop after internal errors#660
Open
duclvz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
Trigger an upstream HTTP 529 (overloaded) from Anthropic during a turn.
Send a prompt:
The error is reported correctly.
Send any second prompt:
It returns end_turn instantly with zero usage instead of running.
Root cause: the failed turn left a trailing
session_state_changed: idlein the SDK query stream. The next prompt’s firstquery.next()consumes that stale idle and short-circuits via the case"session_state_changed"branch with stopReason at its default"end_turn".A secondary issue: any prompts queued behind the failed turn were resolved with false (handoff semantics), which made them try to continue on the broken stream — and only the first one in the queue was resolved at all, leaking the rest forever.
Solve approach
query.interrupt(), then drainquery.next()until the trailingsession_state_changed: idleis consumed. The next prompt now starts against a clean stream.eturns { stopReason: "cancelled" }so the client can decide what to do next, instead of inheriting a poisoned stream.Tests added under
describe("post-error recovery", …):