Allow launchers to skip initial Claude setModel#646
Open
imwalkinhere wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query.setModel(...)call when the model is already baked into the Claude subprocess environmentCLAUDE_AGENT_ACP_SKIP_INITIAL_SET_MODEL=1and the existing OpenClaw-facingCLAUDE_ACP_BAKE_MODEL=1marker as signals to skip the redundant setModel callANTHROPIC_MODELwithout callingsetModelContext
Some ACP launchers select the Claude model before process startup via environment variables. In that mode, immediately replaying
setModelafter initialization can hit provider/runtime paths that are more fragile than launch-time model selection. This keeps the default behavior unchanged unless a launcher explicitly opts into the skip marker.Tests
npm run test:run -- src/tests/acp-agent-settings.test.tsnpm run buildnpm run format:checknpm run lint