Fix AttributeError crash when AgentContext lacks type attribute (#923)#926
Open
frosty720 wants to merge 1 commit intoagent0ai:mainfrom
Open
Fix AttributeError crash when AgentContext lacks type attribute (#923)#926frosty720 wants to merge 1 commit intoagent0ai:mainfrom
frosty720 wants to merge 1 commit intoagent0ai:mainfrom
Conversation
…t0ai#923) Add defensive checks using hasattr() before accessing context.type to prevent AttributeError crashes when dealing with old or corrupted contexts that don't have the type attribute. This fixes the data loss issue reported in agent0ai#923. Changes: - python/helpers/persist_chat.py: Add hasattr checks in save_tmp_chat(), save_tmp_chats(), and _serialize_context() - python/extensions/message_loop_end/_90_save_chat.py: Add hasattr check in SaveChat.execute() - agent.py: Add hasattr check in AgentContext.output() - python/api/poll.py: User's original fix (already applied) All locations now use defensive pattern: if hasattr(context, 'type') and context.type == AgentContextType.BACKGROUND For serialization, default to USER type when attribute is missing: context.type.value if hasattr(context, 'type') else AgentContextType.USER.value Added comprehensive test suite to verify the fixes work correctly with: - Normal contexts (with type attribute) - Contexts without type attribute (bug scenario) - BACKGROUND contexts All tests pass successfully.
Collaborator
|
Thank you, I don't think checking existence of mandatory attribute every time it's used is a way to go. If the attribute is missing, we should rather identify the root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add defensive checks using hasattr() before accessing context.type to prevent AttributeError crashes when dealing with old or corrupted contexts that don't have the type attribute. This fixes the data loss issue reported in #923.
Changes:
All locations now use defensive pattern:
if hasattr(context, 'type') and context.type == AgentContextType.BACKGROUND
For serialization, default to USER type when attribute is missing:
context.type.value if hasattr(context, 'type') else AgentContextType.USER.value
Added comprehensive test suite to verify the fixes work correctly with:
All tests pass successfully.