Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot_time_reverse.py time-reverse simulation #172

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

charlesbmi
Copy link
Contributor

#171

Introduction

Introduction from plot_time_reverse.py:

The skull adds aberrations to the beam propagation; phased arrays can compensate for those by having different delays for each element, but estimating these delays can be challenging. One method to estimate the delays is a "time reverse" simulation as described in this Article. This notebook demonstrates the "time reverse" method to estimate the delays. The notebook sets up a scenario with a phased array source and a target and then runs a simulation with the source and target reversed to calculate the delays. Finally, it uses the calculated delays to perform a forward-time simulation.

The time-reverse simulation was still using an old API .add_source so it had both the default source and the

Changes

  • Remove the default source from the time-reverse simulation

Behavior

  • Tested locally that resulting delays are correct (on the order of 40microseconds)
  • Docs generate properly and show the point-source simulation

@charlesbmi charlesbmi marked this pull request as ready for review October 31, 2023 20:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/neurotechdevkit/results/_metrics.py 100.00% <ø> (ø)
src/neurotechdevkit/results/_results.py 64.28% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-reverse simulation example doesn't show a reverse-simulation properly
2 participants