Skip to content

Conversation

@ruifengx
Copy link
Contributor

List of Changes:

  • Add irrelevant & antisym to Vec.Pointwise.Extensional
  • Add irrelevant & antisym for Vec.Pointwise.Inductive
  • Fix: relax sym & trans to allow different levels

I also checked the corresponding module in Data.List, and I found out that Data.List already have the corresponding definitions, but the naming is not consistent:

  • Data.Vec uses refl, sym, trans (and here I add antisym)
  • Data.List uses reflexive, symmetric, transitive, and antisymmetric

Perhaps the naming should be unified, but I do not know enough for this.

Regarding relaxing the level restrictions, symmtric and transitive in List.Pointwise is already level-polymorphic (the input relations R and S can have different levels) thanks to its use of generalisable variables.

@ruifengx ruifengx changed the title Pointwise [add] irrelevant & antisym to Pointwise for Data.Vec Dec 19, 2025
@Taneb
Copy link
Member

Taneb commented Dec 19, 2025

This all looks great! Can you add your changes to the changelog?

Regarding your point about naming, yes this should be unified, but that doesn't need to happen in this PR

@ruifengx
Copy link
Contributor Author

Done. The CI is triggered again unfortunately. I will remember to do everything in one shot next time.

@MatthewDaggitt MatthewDaggitt added this to the v2.4 milestone Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants