-
Notifications
You must be signed in to change notification settings - Fork 259
[ add ] left- and right- actions induced by a Magma homomorphism
#2894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think this is a good addition, but if these are getting reexported by the various variations of ring morphisms, they should be renamed |
Latest commit adds some of these export renamings. More to follow later, or downstream... most of the multiplicative substructure isn't opened in UPDATED: added renamed exports for |
|
Even if they're not currently opened, it might be worth opening them specifcally to export |
Good suggestion! Incoming commits... |
JacquesCarette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not keen on this design.
| open IsRelHomomorphism isRelHomomorphism public | ||
| renaming (cong to ⟦⟧-cong) | ||
|
|
||
| ⟦_⟧∙_ : A → B → B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fairbairn threshold? Do we really gain anything by adding these synonyms? The code already says we lose a bit (via the need to add hiding).
Personally I think that IsMagmaHomomorphism should be more minimalistic, and we should also have accompanying "extra kit" modules that we can use when needed. I've partially refactored agda-categories in that direction. And, in that case, seriously shrank the size of .agdai files and load times. I don't expect such an effect for Magma-related stuff, but this more "kitchen-sink" design approach is exactly what made working with Monoidal Categories so heavy.
A simple piece of 'infrastructure' for
Algebra.NB. used extensively (implicitly) in #2854 etc. cf. #2892 and #2350 .
Issues: