Share the proofs of ×-comm and ⊎-comm of type isomorphisms and add a pairing operation#2868
Merged
Taneb merged 4 commits intoagda:masterfrom Dec 29, 2025
Merged
Share the proofs of ×-comm and ⊎-comm of type isomorphisms and add a pairing operation#2868Taneb merged 4 commits intoagda:masterfrom
Taneb merged 4 commits intoagda:masterfrom
Conversation
JacquesCarette
approved these changes
Nov 11, 2025
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
I was afraid (from the description) that this might make a mess of the dependency graph. But it seems not - great.
So this looks like a nice simplification.
Contributor
Author
|
@MatthewDaggitt Is this good to go? |
Taneb
approved these changes
Dec 29, 2025
Contributor
Author
|
Thanks! |
plt-amy
pushed a commit
that referenced
this pull request
Feb 9, 2026
…pairing operation (#2868) * Share Sum and Product type isomorphism proof * Add pairing of type isomorphism * Update CHANGELOG for the new functions * cosmetic changes: limit Data.Sum.Base imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions
Function.Related.TypeIsomorphism.⊎-commandData.Sum.Properties.swap-↔are the same, thus this PR points one to the other.Function.Related.TypeIsomorphism.∃∃↔∃∃is similar as well.To make things parallel, this PR keeps only the name of
Function.Related.TypeIsomorphism.×-command moves its implementation toData.Product.Properties.Finally, this PR adds
_,′-↔_ : A ↔ C → B ↔ D → (A × B) ↔ (C × D)that pairs two type isomorphisms.(The type of
_,′-↔_can't be expressed as_×_ Preserves₂ _↔_ ⟶ _↔_ ⟶ _↔_because that requiresAandCto have identicalLevels and similarlyBandDwould need to have the sameLevel.)