Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add content to metadata summary #71

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

crsct
Copy link
Collaborator

@crsct crsct commented Nov 14, 2023

closes #58 by adding proposed values to the summary card

Copy link
Member

@lukasjelonek lukasjelonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complexity can be reduced by the mentioned changes

src/components/EnvironmentMetadata.vue Outdated Show resolved Hide resolved
src/views/show-results/DisplayMetadata.vue Outdated Show resolved Hide resolved
Copy link
Member

@lukasjelonek lukasjelonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code perspective this looks good.
From the functionality perspective all fields should be visible everytime, see comment.

src/views/show-results/DisplayMetadata.vue Outdated Show resolved Hide resolved
@lukasjelonek lukasjelonek merged commit 42937af into main Nov 23, 2023
1 check passed
@lukasjelonek lukasjelonek deleted the feature/add-content-to-metadata-summary branch November 23, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content to metadata summary card
2 participants