Refactor: WeaponState, AutoAttackState

[mariamatthews]

• Redefined IsUnsheathed (0x00), SheatheCooldown (0x04), AutoSheathTimer (0x08), and AutoSheatheState (0x0C).
• Deprecated the embedded AutoAttackState at 0x10 (now managed globally via DAT_142921510).
• Added Tick, SetUnsheathed, and SetUnsheathed2 and other methods with updated signatures.
• Revised AutoAttackState interop with SetImpl, Get, and a global binding via Instance().
• Updated data.yml to reflect context and current implementation.

[wolfcomp]

Everything listed has to be changed before even looking at the sigs.

[Haselnussbomber]

Heya. Just in case you don't know: the GitHub Action is is comparing your branch with the current main branch.
Since yours is older it's missing things, so it complains about it.
You can rebase or merge main onto your branch, or ignore what it posted.

[mariamatthews]

Heya. Just in case you don't know: the GitHub Action is is comparing your branch with the current main branch. Since yours is older it's missing things, so it complains about it. You can rebase or merge main onto your branch, or ignore what it posted.

Hi @Haselnussbomber! I thought it might be the case - I should have merged main in first, apologies!
Let me know what do you think about the new code update or if I should merge in the main and generate another run :)

[wolfcomp]

Task failed.

[wolfcomp]

Some wrong defined methods that needs to be fixed.

[mariamatthews]

Quick question about the automated check reporting:

Breaking Changes
Member exists in left but not in right
WeaponState: bool IsAutoAttacking

This seems to be triggered because the original metadata defined this offset as a simple bool, whereas we now explicitly define it as a struct (AutoAttackState).

Is this something I need to address, or is it safe to ignore?

[Haselnussbomber]

It's fine in this case and safe to ignore.
This field had the Obsolete attribute with error set to true on it. Due to the API bump plugins have to be recompiled and that error would prevent a successful compilation, until the code was changed to not use that field anymore.
We would have removed it soon anyway.