Skip to content

Conversation

@rambleraptor
Copy link
Member

Fixes #112

This does two things:

  • Makes sure that we use resource_reference_child_type
  • Changes GetResourceReference to return a struct instead of creating a google.api.resource_reference. We shouldn't have a dependency on that proto message anymore.

@rambleraptor
Copy link
Member Author

@ethanoroshiba @andrew-womeldorf please take a look! This should address your issues.

@ethanoroshiba
Copy link

Allowing resource_reference to point to the child type in List* methods breaks this lint I think, since this mandates that the resource_reference annotation on the parent field refer to the parent of the listed type, as opposed to the listed type itself. This logic looks like it existed previously, though, so maybe you'd ticket it separately. Aside from that, LGTM.

@andrew-womeldorf
Copy link

This fixed my issue, once I added the new resource_reference_child_type annotations. Thanks!

@rambleraptor
Copy link
Member Author

@ethanoroshiba do you mind filing a ticket for that?

@ethanoroshiba
Copy link

@rambleraptor issue open for that here: #116

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock those broken by the previous change, but following up on #116 makes a lot of sense.

@rambleraptor rambleraptor merged commit 6710c15 into main Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rules 132 and 133 check for a non-existent field

5 participants