Road to v3 #33
Draft
Road to v3 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed ‘googlemap’ to ‘googlemaps’ - Updated Vue component to the latest version - Fixed a compilation issue with Cloud Config pages
…aem-core into styleguide-updates
To make it easier to extend, this change changes the visibility level of `getCloudConfigurations` to public which allows it to be overriden at the client level.
# Conflicts: # aemdesign-aem-common/src/main/content/jcr_root/apps/aemdesign/components/layout/parsys/parsys.jsp
This previous implementation causes issues where some CSS may be expecting a different element to be first which breaks it
The injection annotations don’t have to have worked for a while now and don’t do anything at runtime
This was designed to make generating format expressions far more simple, you can pass 1 field or as many as you’d like. `getFormatExpression(“title”)`
- Added `isHasTitle` for detecting when the title is invalid - Added `isUseContainer` to determine if the wrapping container should be used - Added `isShowBreadcrumb` to determine if the breadcrumbs component needs to be available - Added `isShowParsys` to determine if the authorable section of Page Details should be available - Added `isParsysWithAuthoredContent` to determine if the authorable section of Page Details has content within it
The `TemplateSupport` model enables dynamic component paths to be generated using an invoked `Map` which automatically resolves the compoent path using `QueryBuilder`. This is the first draft of the implementation and dynamic tenant assignment via an OSGI configuration is not currently available.
This change was made to make it easier to extend and implement generic behaviours for invocator classes that may reuse some logic.
…-core into task/road-to-v3
Up until now the expression requires to get the tenant (actually `namespace`) was complex and not extensible. This first pass introduces `${namespace}` which encapsulates the logic and allows for future updates by which the namespace can be 100% dynamic based on its context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are in conjunction to updates in the aem-design/aemdesign-aem-support#26 project.
What is covered: