Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY configuration for webant #4

Closed
wants to merge 2 commits into from
Closed

DRY configuration for webant #4

wants to merge 2 commits into from

Conversation

boyska
Copy link

@boyska boyska commented Mar 15, 2016

No description provided.

@ael-code
Copy link
Owner

'API_URL': '/api/v1',
'RESULTS_PER_PAGE': 30,
'MAX_RESULTS_PER_PAGE': 100

are still duplicated

@boyska
Copy link
Author

boyska commented Mar 16, 2016

ael:

'API_URL': '/api/v1',
'RESULTS_PER_PAGE': 30,
'MAX_RESULTS_PER_PAGE': 100

are still duplicated

fixed

@ael-code
Copy link
Owner

defaults = conf

this is not necessary.
Anyway I think that we are loosing some of the modularization that we achieve using sub-classing pattern.

According to me the problem of duplicated configuration is not strictly related to this PR but is a bigger design problem to which I would like to dedicate some more time.

@boyska boyska mentioned this pull request Mar 16, 2016
Open
@boyska
Copy link
Author

boyska commented Mar 16, 2016

Ok, I'm opening insomnia-lab#273 and closing this

@ael-code ael-code closed this Mar 17, 2016
@boyska boyska deleted the pagination branch July 28, 2016 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boyska @ael-code