Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement correct unnesting operators in extract() #2220

Merged
merged 13 commits into from
Mar 26, 2025
Merged

Implement correct unnesting operators in extract() #2220

merged 13 commits into from
Mar 26, 2025

Conversation

piotrszul
Copy link
Collaborator

Resolves #2068

piotrszul added 9 commits March 7, 2025 17:22
@piotrszul
Implementing head() and tail() for binary operator paths and adding t…
7f5a459 
…est cases for implicit unnesting of operators in extract().
@piotrszul
Adding more test cases for implicit un-nesting.
6ccfbe5
@piotrszul
Fixing the issues with unnesting of operators and aggreations and rep…
bc64ea6 
…eated paths.
@piotrszul
Implementing correct ordering of result columns for extract (to match…
d9deac0 
… to order of extract selection paths.
@piotrszul
Implementing correct ordering of result columns for extract (to match…
54229d7 
… to order of extract selection paths.
@piotrszul
Making prefix/suffix of fhir path independent of head/tail as both ar…
b3336a0 
…e needed in different contexts.
@piotrszul
Removing duplicate implementation of This() fhir path. $this is now r…
dcd1333 
…epresented by the nullPath().
@piotrszul
Enabling all remaining AggregateQueryTests cases and updating expecta…
4be7fb0 
…tions to match current FhirPath to fhir expression conversion.
@piotrszul
Enabling running of search after each of AggregateQueryTest cases.
11ca253
@piotrszul piotrszul self-assigned this Mar 11, 2025
@piotrszul piotrszul added the bug Something isn't working label Mar 11, 2025
@piotrszul piotrszul added this to the v8.0.0 milestone Mar 11, 2025
@piotrszul piotrszul requested a review from johngrimes March 14, 2025 00:09
@piotrszul
Copy link
Collaborator Author

piotrszul commented Mar 14, 2025 •
edited
Loading

@johngrimes would you mind having a lookin at this pool request, in particular on the ImplicitUnnester , ExtractQueryExecutor, ImplicitUnnesterTest , and ExtactQueryTest, plus fhirpath/UNNESTING.md.
I have made some assumptions about how the unnesting should work in some cases that have not been covered by existing test cases that I would like you to check. More details in #2068

@piotrszul
Merge branch 'release/8.0.0' into issue/2068
db70cdc 
# Conflicts:
#	fhirpath/src/main/java/au/csiro/pathling/fhirpath/execution/DataRootResolver.java
#	fhirpath/src/main/java/au/csiro/pathling/fhirpath/execution/ExecutorUtils.java
#	fhirpath/src/main/java/au/csiro/pathling/fhirpath/function/provider/ResolverFunctions.java
@piotrszul
Fixing merging issues (mostly updating the use of FhirPath head() and…
ddd41e0 
… tail()).
@piotrszul piotrszul merged commit 01ec6ab into release/8.0.0 Mar 26, 2025
18 checks passed
@piotrszul piotrszul deleted the issue/2068 branch March 26, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngrimes johngrimes Awaiting requested review from johngrimes

Assignees

@piotrszul piotrszul

Labels
bug Something isn't working
Projects
Pathling
Status: Done
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@piotrszul