Implement fhirpath.js test runner.#2177
Conversation
…ce FHIR evaluation.
…he actual result.
…omparison issues.
…traversal to undefined fields.
…c test cases for empty() and count() functions.
…siro.pathling.test.yaml.logLevel` system property to control the logging level for the tests.
…nce passing existence function test cases in the build.
…ling Fhirpath test cases.
…ling Fhirpath test cases.
…ry.yaml' and 'hasValue.yaml'
…o singular values).
…n surefire reports.
johngrimes
left a comment
johngrimes
left a comment
There was a problem hiding this comment.
Thanks @piotrszul, I had a few questions.
There was a problem hiding this comment.
Would fhirpath/test/python be a more natural place to put these files?
There was a problem hiding this comment.
Moved to fhirpath/test/python
There was a problem hiding this comment.
It's unclear to me what these Def* classes are for.
Perhaps some different naming or class comments would help.
There was a problem hiding this comment.
These are the 'Default' implementations - added javadocs comment to all these classes.
There was a problem hiding this comment.
What is a ResourceTag? Does it have any overlap in meaning with a TypeSpecifier?
There was a problem hiding this comment.
It's an abstract representation of a resource type (that can in principle be used to represent any resource type also such that are not defined in FHIR). Added javadocs to the class.
There was a problem hiding this comment.
How many of these implementations of FhirpathEvaluator are we actually using, and what are we using them for?
There was a problem hiding this comment.
Raised as: #2189 (Review and cleanup the the FhirpathEvaluator implementations)
2 participants
Resolves #2071