Fix combination count check for fourth order searches #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program terminates with an error when checking the total number of combinations explored due to differences in precision between double precision types and unsigned integers.
When I run
./BitEpi -bfile -i sampleData/bfile.bed -t 1 -b4 1 -o test.txt
using the sample data sets, I obtain:The problematic line is:
BitEpi/BitEpi.cpp
Line 2281 in a23e2ad
If you compare integers and doubles like that, a small diference in precision carried over numerous operations may change the boolean outcome. The commit included in this pull request fixes this problem.