Skip to content

Dark theme: loan - #700

Open
Marc-Andrieu wants to merge 3 commits into
dark/corefrom
dark/loan
Open

Dark theme: loan#700
Marc-Andrieu wants to merge 3 commits into
dark/corefrom
dark/loan

Conversation

@Marc-Andrieu

@Marc-Andrieu Marc-Andrieu commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

Summary

See the core PR #671, the current PR is to be merged into the core one.

Changes Made

  • pages
    • admin_page
      • admin_page
      • delay_dialog
      • item_card
      • loan_card
      • loan_history
      • loaners_bar
      • loaners_items
      • on_going_loan
    • detail_pages
      • detail_loan
      • item_card_in_loan
    • item_group_page
    • loan_group_page
      • add_edit_button
      • add_edit_loan_page
      • check_item_card
      • end_date_entry
      • item_bar
      • number_selected_text
      • search_result
      • start_date_entry
    • main_page
  • loan

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this Aug 7, 2026
@Marc-Andrieu Marc-Andrieu added enhancement New feature or request loan labels Aug 7, 2026
@codecov-commenter

codecov-commenter commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.61%. Comparing base (e5f3b67) to head (7376227).

Additional details and impacted files
@@            Coverage Diff             @@
##           dark/core     #700   +/-   ##
==========================================
  Coverage      50.61%   50.61%           
==========================================
  Files            169      169           
  Lines           3839     3839           
==========================================
  Hits            1943     1943           
  Misses          1896     1896           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu added the ready for review This PR is ready to be reviewed label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request loan ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants