Skip to content

Add permissions factory - #1047

Merged
Rotheem merged 1 commit into
mainfrom
permission-factory
Aug 16, 2026
Merged

Add permissions factory#1047
Rotheem merged 1 commit into
mainfrom
permission-factory

Conversation

@Rotheem

@Rotheem Rotheem commented Aug 16, 2026

Copy link
Copy Markdown
Member

Description

Summary

Add permissions factory with all permissions for admin

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@Luhmos Luhmos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.06%. Comparing base (1b6e029) to head (56b8bcd).

Files with missing lines Patch % Lines
app/core/permissions/factory_permissions.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   85.05%   85.06%           
=======================================
  Files         219      220    +1     
  Lines       16230    16248   +18     
=======================================
+ Hits        13805    13821   +16     
- Misses       2425     2427    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rotheem
Rotheem merged commit 4379a3d into main Aug 16, 2026
7 checks passed
@Rotheem
Rotheem deleted the permission-factory branch August 16, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants