Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix galaxy generation #722

Open
wants to merge 1 commit into
base: taiste
Choose a base branch
from
Open

Fix galaxy generation #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion galaxy/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def compute_users_clubs_score(cls, user1: User, user2: User) -> int:
(earliest_end - latest_start).days,
)
)
score += cls.CLUBS_POINTS * (earliest_end - latest_start).days
score += cls.CLUBS_POINTS * abs((earliest_end - latest_start).days)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si le nombre de jours pouvait se retrouver en négatif, est-ce que ça ne veut pas dire que le calcul de la durée d'appartenance commune à un club est faux ?

Est-ce qu'on est sûr qu'on nest pas en train d'augmenter le score entre deux utilisateurs alors que leurs adhésions n'intersectionnent pas ?

return score

###################
Expand Down
Loading