Fix:Crash when author is set without a name #1934

advplyr · Jul 19, 2023 · c2793fe · c2793fe
1 parent 24b9ac6
commit c2793fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/server/controllers/AuthorController.js b/server/controllers/AuthorController.js
@@ -165,7 +165,7 @@ class AuthorController {
     var q = (req.query.q || '').toLowerCase()
     if (!q) return res.json([])
     var limit = (req.query.limit && !isNaN(req.query.limit)) ? Number(req.query.limit) : 25
-    var authors = Database.authors.filter(au => au.name.toLowerCase().includes(q))
+    var authors = Database.authors.filter(au => au.name?.toLowerCase().includes(q))
     authors = authors.slice(0, limit)
     res.json({
       results: authors

diff --git a/server/objects/entities/Author.js b/server/objects/entities/Author.js
@@ -57,7 +57,10 @@ class Author {
 
   setData(data, libraryId) {
     this.id = uuidv4()
-    this.name = data.name
+    if (!data.name) {
+      Logger.error(`[Author] setData: Setting author data without a name`, data)
+    }
+    this.name = data.name || ''
     this.description = data.description || null
     this.asin = data.asin || null
     this.imagePath = data.imagePath || null