Skip to content

Adverserial use of `make_bitflags!` macro can cause undefined behavior

Moderate severity GitHub Reviewed Published Apr 24, 2023 to the GitHub Advisory Database • Updated Apr 24, 2023

Package

cargo enumflags2 (Rust)

Affected versions

>= 0.7.0, < 0.7.7

Patched versions

0.7.7

Description

The macro relied on an expression of the form Enum::Variant always being a
variant of the enum. However, it may also be an associated integer constant, in
which case there's no guarantee that the value of said constant consists only of
bits valid for this bitflag type.

Thus, code like this could create an invalid BitFlags<Test>, which would cause
iterating over it to trigger undefined behavior. As the debug formatter
internally iterates over the value, it is also affected.

use enumflags2::{bitflags, make_bitflags};

#[bitflags]
#[repr(u8)]
#[derive(Copy, Clone, Debug)]
enum Test {
    A = 1,
    B = 2,
}

impl Test {
    const C: u8 = 69;
}

fn main() {
    let x = make_bitflags!(Test::{C});
    // printing or iterating over x is UB
}

References

Published to the GitHub Advisory Database Apr 24, 2023
Reviewed Apr 24, 2023
Last updated Apr 24, 2023

Severity

Moderate

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-qvc4-78gw-pv8p
Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.