Skip to content

Insecure path traversal in Git Trigger Source can lead to arbitrary file read

High severity GitHub Reviewed Published Jun 13, 2022 in argoproj/argo-events • Updated Aug 28, 2023

Package

gomod github.com/argoproj/argo-events (Go)

Affected versions

< 1.7.1

Patched versions

1.7.1

Description

Impact

A path traversal issue was found in the (g *GitArtifactReader).Read() API. Read() calls into (g *GitArtifactReader).readFromRepository() that opens and reads the file that contains the trigger resource definition:

func (g *GitArtifactReader) readFromRepository(r *git.Repository, dir string)

No checks are made on this file at read time, which could lead an attacker to read files anywhere on the system. This could be achieved by either using symbolic links, or putting ../ in the path.

Patches

A patch for this vulnerability has been released in the following Argo Events version:

v1.7.1

Credits

Disclosed by Ada Logics in a security audit sponsored by CNCF and facilitated by OSTIF.

For more information

Open an issue in the Argo Events issue tracker or discussions
Join us on Slack in channel #argo-events

References

@whynowy whynowy published to argoproj/argo-events Jun 13, 2022
Published to the GitHub Advisory Database Jun 17, 2022
Reviewed Jun 17, 2022
Published by the National Vulnerability Database Jun 17, 2022
Last updated Aug 28, 2023

Severity

High
7.5
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
None
Availability
None
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N

Weaknesses

CVE ID

CVE-2022-25856

GHSA ID

GHSA-qpgx-64h2-gc3c

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.