Compatibiliy with Windows fixing the /bin/sh problem. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not) and use that to predict if we use /bin/sh or cmd. Has been tested on a windows+eclipse machine and works
hudsonmendes
changed the title
…herefore we are now conditionally deciding the delimiter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today I had this problem trying to run a gradle build from eclipse: it would not run
startTestDockerbecause it attempted to create the process using/bin/sh -c, and that would work in my MINGW64, but fail in my Eclipse.After I created the issue (#2), I did some investigation, fixed the problem and finally tested it in my own project. It works like a charm.
Using the gradle plugin framework, we now identify the OS (windows or not) and use that to predict if we use /bin/sh or cmd. Has been tested on a windows+eclipse machine and works.
I hope you enjoy this contrib.