Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended talks #64

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Recommended talks #64

merged 5 commits into from
Oct 23, 2023

Conversation

adrienpoly
Copy link
Owner

This PR is preparation work to isolate the recommended talks into a dedicated controller.

The logic that is being built in #19 can be then added to the Talks#related_talks method

@useattractor
Copy link

useattractor bot commented Oct 23, 2023

Recommended talks 🔗

Stats

Language Score Trend
Ruby 68.83 (from 68.83) 📉 0.0%
JavaScript 84.95 (from 84.95) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected app/models/talk.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@@ -0,0 +1,5 @@
<%= turbo_frame_tag "recommended_talks" do %>
<div data-turbo-temporary data-controller="transition" class="hidden" data-transition-enter-after-value="0">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah first time I really use it but very helpful here to avoid a page blink

@useattractor
Copy link

useattractor bot commented Oct 23, 2023

Recommended talks 🔗

Stats

Language Score Trend
Ruby 69.23 (from 68.83) 📈 0.58%
JavaScript 84.95 (from 84.95) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby app/controllers/talks_controller.rb app/models/talk.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@useattractor
Copy link

useattractor bot commented Oct 23, 2023

Recommended talks 🔗

Stats

Language Score Trend
Ruby 69.23 (from 68.83) 📈 0.58%
JavaScript 84.95 (from 84.95) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby app/controllers/talks_controller.rb app/models/talk.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@adrienpoly adrienpoly merged commit f3b0f80 into main Oct 23, 2023
3 checks passed
@adrienpoly adrienpoly deleted the recommended-talks branch October 23, 2023 20:40
@adrienpoly adrienpoly mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants