Avo: Improve talks index page, improve talks fields position, enable talks search #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marcoroth
commented
Aug 19, 2024
marcoroth
commented
adrienpoly
added a commit
that referenced
this pull request
Aug 31, 2024
* RailsConf cleanup and formatting * remove ocker warnings * Add Baltic Ruby 2024 videos (#90) * Add Baltic Ruby 2024 videos * Cleanup --------- Co-authored-by: Adrien Poly <[email protected]> * Add Euruko videos (#98) * Add Euruko videos * Remove non-talks videos * remove city presentation speakers * Add rubyday videos (#106) * Add rubyday videos * Add rubyday 2014-2016 too * update dates --------- Co-authored-by: Adrien Poly <[email protected]> * increase timeout * set edit page canonical url * add admin tools * Fix Matz's name in Euruko 2022 Keynote (#119) * Upgrade Rails to `7.2.0` (#121) * Upgrade Ruby to `3.3.4` (#122) * update all Matz to Yukihiro "Matz" Matsumoto * Only show speakers with talks on speakers index (#126) * seed find by slug (#124) * Run CI on Pull Requests (#125) * Implement Talk Topics (#123) * Topics * fix typos * add scopes with and without topics * add avo action * update prompt addd test with fixture * update seed * perform_later * remove analyse job from show view * remove puts * update solid_queue * add new migrations for solid queue * add uniq index on topic name * normalize name * lint * improve admin with filter by name for topics * Downgrade minitest to `5.24.1` Minitest `5.25.0` broke the parallel execution of tests. See: minitest/minitest#1007 * Fix topic controller tests * Add `published` column to `topics` * Use secondary badge style * Add `slug` to `topics` * Improve topics list * `desciption` -> `description` * Cleanup * More topics --------- Co-authored-by: Adrien Poly <[email protected]> * Prevent duplicates (#127) * add test to ensure we don't create duplicates * add uniq index on talk_topic to prevent duplicates * remove duplicate topic in seed * add more admin tools to manage topics (#128) * Status enum for topics (#129) * add a status for the topic instead on the boolean * remove n+1 * add reject action and rename publish action to approve * Poor man FF (#130) * poor man FF * fix tests * update ruby lsp * Fix published migration (#131) * add more topics filter * fix approved_topics scope * Don't reset already approved Topic when creating new topics (#132) * Update Meta Tags to Rails 7.2 (#133) * add dependent destroy for topic_talks and remove closing talk from rails conf 24 * add topics with talk filter * remove rails conf 24 conference welcome talk * remove welcome talks * prevent CI to run twice on PR * Add `frozen_record` to query static data in ActiveRecord-style (#120) Co-authored-by: Adrien Poly <[email protected]> * add the rejected list to the prompt (#136) * add canonical topic with admin tools (#135) * Update talk from metadata tools (#118) * add the ability to filter talks by event * add action to update from yml file * fix test * update using static frozen records * fix typo * Rejected destroy talk topics (#139) * handle rejected! * add duplicate to the filters * add canonicla to the topic index admin view * Add RubyKaigi videos (#107) Co-authored-by: Adrien Poly <[email protected]> * update dates for ruby kaigi * display transcript as text in admin * remove minitest locked version * Add RubyConf TH videos (#113) * Add Tropical.rb 2024 videos (#108) * lint * lint * Add wroc_love.rb videos (#117) Co-authored-by: Adrien Poly <[email protected]> * Add Balkan Ruby videos (#109) Co-authored-by: Adrien Poly <[email protected]> * Add Ruby on Ice 2019 videos (#110) Co-authored-by: Adrien Poly <[email protected]> * Add Ancient City Ruby videos (#112) Co-authored-by: Adrien Poly <[email protected]> * Add Paris.rb Conf videos (#115) Co-authored-by: Adrien Poly <[email protected]> * Add `language` column to `Talk` (#140) * Upgrade `avo` to `3.11.7` (#141) * Add Ruby Unconf 2018 and 2019 videos (#114) * Fallback to `en` if no valid language is found (#142) * Improve position of fields, rework what's show on index, and enable search (#143) * Fix icon in footer (#145) * Workaround for language filter (#146) * Upgrade `mission_control-jobs` gem (#149) * Enable `speaker_tags` for `Talk` resource (#148) * Remove `year` column from `Talk` model (#144) Co-authored-by: Adrien Poly <[email protected]> * add event page (#39) * setup enviroment * add events#show system test * add association between event one and talks one fixtures * add events#show following same structure as speakers#show * add navigation link to events#show on talks/card partial * refac event about into partial * fix lint, using double quote instead of single quotes * fix gemfile.lock conflicts * update gemfile.lock to match the main branch * add link to event show back to talks/card * update gitignore * add simple test (and fixture) for events#index and events#index filtered * add events#index following speakers#index * Refac events system test and events views tom easily test * fix linter errors * add test to ensure events index is ordering collection * fix linter * lint * remove admin duplicated link * add organisation name to view in order to better organize events index page * add items-center to fix events talks count badge alignment when event name does not fit in one line * add counter cache removes n+1 --------- Co-authored-by: Adrien Poly <[email protected]> * limit to 21 talks (#156) * default to en when language is nil or invalid (#150) * dafult to en when language is nil or invalid * only default to en when language is nil * update tests description * Improve responsive styles for topic tags and topics show page (#158) * Improve topic tags responsive-ness * Improve topics show page * update git ignore * RailsConf cleanup and formatting --------- Co-authored-by: Adrien Poly <[email protected]> Co-authored-by: André Menezes <[email protected]>
marcoroth
added a commit
to marcoroth/rubyvideo
that referenced
this pull request
Oct 19, 2024
* RailsConf cleanup and formatting * remove ocker warnings * Add Baltic Ruby 2024 videos (adrienpoly#90) * Add Baltic Ruby 2024 videos * Cleanup --------- Co-authored-by: Adrien Poly <[email protected]> * Add Euruko videos (adrienpoly#98) * Add Euruko videos * Remove non-talks videos * remove city presentation speakers * Add rubyday videos (adrienpoly#106) * Add rubyday videos * Add rubyday 2014-2016 too * update dates --------- Co-authored-by: Adrien Poly <[email protected]> * increase timeout * set edit page canonical url * add admin tools * Fix Matz's name in Euruko 2022 Keynote (adrienpoly#119) * Upgrade Rails to `7.2.0` (adrienpoly#121) * Upgrade Ruby to `3.3.4` (adrienpoly#122) * update all Matz to Yukihiro "Matz" Matsumoto * Only show speakers with talks on speakers index (adrienpoly#126) * seed find by slug (adrienpoly#124) * Run CI on Pull Requests (adrienpoly#125) * Implement Talk Topics (adrienpoly#123) * Topics * fix typos * add scopes with and without topics * add avo action * update prompt addd test with fixture * update seed * perform_later * remove analyse job from show view * remove puts * update solid_queue * add new migrations for solid queue * add uniq index on topic name * normalize name * lint * improve admin with filter by name for topics * Downgrade minitest to `5.24.1` Minitest `5.25.0` broke the parallel execution of tests. See: minitest/minitest#1007 * Fix topic controller tests * Add `published` column to `topics` * Use secondary badge style * Add `slug` to `topics` * Improve topics list * `desciption` -> `description` * Cleanup * More topics --------- Co-authored-by: Adrien Poly <[email protected]> * Prevent duplicates (adrienpoly#127) * add test to ensure we don't create duplicates * add uniq index on talk_topic to prevent duplicates * remove duplicate topic in seed * add more admin tools to manage topics (adrienpoly#128) * Status enum for topics (adrienpoly#129) * add a status for the topic instead on the boolean * remove n+1 * add reject action and rename publish action to approve * Poor man FF (adrienpoly#130) * poor man FF * fix tests * update ruby lsp * Fix published migration (adrienpoly#131) * add more topics filter * fix approved_topics scope * Don't reset already approved Topic when creating new topics (adrienpoly#132) * Update Meta Tags to Rails 7.2 (adrienpoly#133) * add dependent destroy for topic_talks and remove closing talk from rails conf 24 * add topics with talk filter * remove rails conf 24 conference welcome talk * remove welcome talks * prevent CI to run twice on PR * Add `frozen_record` to query static data in ActiveRecord-style (adrienpoly#120) Co-authored-by: Adrien Poly <[email protected]> * add the rejected list to the prompt (adrienpoly#136) * add canonical topic with admin tools (adrienpoly#135) * Update talk from metadata tools (adrienpoly#118) * add the ability to filter talks by event * add action to update from yml file * fix test * update using static frozen records * fix typo * Rejected destroy talk topics (adrienpoly#139) * handle rejected! * add duplicate to the filters * add canonicla to the topic index admin view * Add RubyKaigi videos (adrienpoly#107) Co-authored-by: Adrien Poly <[email protected]> * update dates for ruby kaigi * display transcript as text in admin * remove minitest locked version * Add RubyConf TH videos (adrienpoly#113) * Add Tropical.rb 2024 videos (adrienpoly#108) * lint * lint * Add wroc_love.rb videos (adrienpoly#117) Co-authored-by: Adrien Poly <[email protected]> * Add Balkan Ruby videos (adrienpoly#109) Co-authored-by: Adrien Poly <[email protected]> * Add Ruby on Ice 2019 videos (adrienpoly#110) Co-authored-by: Adrien Poly <[email protected]> * Add Ancient City Ruby videos (adrienpoly#112) Co-authored-by: Adrien Poly <[email protected]> * Add Paris.rb Conf videos (adrienpoly#115) Co-authored-by: Adrien Poly <[email protected]> * Add `language` column to `Talk` (adrienpoly#140) * Upgrade `avo` to `3.11.7` (adrienpoly#141) * Add Ruby Unconf 2018 and 2019 videos (adrienpoly#114) * Fallback to `en` if no valid language is found (adrienpoly#142) * Improve position of fields, rework what's show on index, and enable search (adrienpoly#143) * Fix icon in footer (adrienpoly#145) * Workaround for language filter (adrienpoly#146) * Upgrade `mission_control-jobs` gem (adrienpoly#149) * Enable `speaker_tags` for `Talk` resource (adrienpoly#148) * Remove `year` column from `Talk` model (adrienpoly#144) Co-authored-by: Adrien Poly <[email protected]> * add event page (adrienpoly#39) * setup enviroment * add events#show system test * add association between event one and talks one fixtures * add events#show following same structure as speakers#show * add navigation link to events#show on talks/card partial * refac event about into partial * fix lint, using double quote instead of single quotes * fix gemfile.lock conflicts * update gemfile.lock to match the main branch * add link to event show back to talks/card * update gitignore * add simple test (and fixture) for events#index and events#index filtered * add events#index following speakers#index * Refac events system test and events views tom easily test * fix linter errors * add test to ensure events index is ordering collection * fix linter * lint * remove admin duplicated link * add organisation name to view in order to better organize events index page * add items-center to fix events talks count badge alignment when event name does not fit in one line * add counter cache removes n+1 --------- Co-authored-by: Adrien Poly <[email protected]> * limit to 21 talks (adrienpoly#156) * default to en when language is nil or invalid (adrienpoly#150) * dafult to en when language is nil or invalid * only default to en when language is nil * update tests description * Improve responsive styles for topic tags and topics show page (adrienpoly#158) * Improve topic tags responsive-ness * Improve topics show page * update git ignore * RailsConf cleanup and formatting --------- Co-authored-by: Adrien Poly <[email protected]> Co-authored-by: André Menezes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.