Add a WithTimescaleDB option to support using the Timescale PG compatible images #19
Conversation
This allows support for using Postgres compatible images such as
TimescaleDB via:
```
psqldocker.NewContainer(
u, p, dbname,
psqldocker.WithRepository("timescale/timescaledb-ha"),
psqldocker.WithImageTag("pg15-latest"),
)
```
|
The aim is to maintain a focused approach for this project. maintaining compatibility with select Postgres repositories rather than broad support for any Docker image. In line with this strategy, it's more appropriate to provide options for specific PostgreSQL Docker repositories, with the "postgres" repository being the default one. For instance, instead of a generic Also if you intend to update the PR to conform to the above-mentioned ideas, please provide a test case for the new option. Let me know if I can help in any way! |
|
That makes sense to me. I'll update the PR. Thanks for the feedback and taking a look! |
This adds the WithTimescaleDB option, which sets the repo to "timescale/timescaledb" and also sets a valid image tag as the "alpine" default is not compatible. It only updates the tag when it is default.
ionrock
changed the title
|
@adrianbrad I updated the PR. Let me know what you think! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 88.20% 88.78% +0.58%
==========================================
Files 2 2
Lines 212 223 +11
==========================================
+ Hits 187 198 +11
Misses 17 17
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Excellent 👌. I will bump deps and realease a new version. |
|
Fantastic! Thanks so much! |
This allows support for using Postgres compatible images such as TimescaleDB via: