-
Notifications
You must be signed in to change notification settings - Fork 2
set up a cluster for local deployement of the server for testing #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First , please bear in mind the helm chart which is already existing is fucntional. For local testing , I suggest you create a new directory and have files very similar to what we already have becuase
- You wlll not necessarily need to enable ssl or tls while testting locally.
- Redis url will need to change :
"redis://:$(REDIS_PASSWORD)@{{ .Release.Name }}-redis-master.{{ .Release.Namespace }}.svc.cluster.local:6379"
- Also , I do not know how you were able to test given that , bitnami is migrating their free Docker images away from the original
docker.io/bitnami
organization on Docker Hub, hte images have been moved to a legacy repository atdocker.io/bitnamilegacy
. I was not even able to pull because of that.
But finally tested with my setup on minikube
You can refer to some changes done here. Riuhgky done to test but you can make somehting better from it for local tetsing configurations: https://github.com/adorsys/status-list-server/tree/test-deployemnt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to address @Ogenbertrand
When done, I will test the script
5d72518
to
7d6817d
Compare
7d6817d
to
59ab67c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Ogenbertrand, l have added some comments. Please could you take a look?
Also, I tested the script and it worked.
helm/status-list-server-chart-local/k8s-deployment-review-feedback.md
Outdated
Show resolved
Hide resolved
helm/status-list-server-chart-local/k8s-deployment-review-feedback.md
Outdated
Show resolved
Hide resolved
@forkimenjeckayang and @mbunwe-victor the PR is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few coments to check @Ogenbertrand
Your script works.
Just adjust the few comments , it will help avoid this warning.
[INFO] Installing Helm chart...
I1007 09:46:22.397561 2948695 warnings.go:110] "Warning: spec.template.spec.containers[0].env[16].name: duplicate name \"POSTGRES_PASSWORD\""
NAME: status-list-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Ogenbertrand, for addressing my comments—just this last comment.
helm/status-list-server-chart-local/k8s-deployment-review-feedback.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressing this should be all from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @Ogenbertrand, help check these last comments. So, as mentioned in the doc file, I achieved this with the suggestions I added.
status-list-server git:(feat-test-deployement-k8s) ✗ ./k8s-deployment-test.sh status
[INFO] Deployment Status:
Namespace: statuslist
Cluster: status-list-test
[INFO] Pods:
NAME READY STATUS RESTARTS AGE
status-list-server-local-6df565b46c-4gq6d 1/1 Running 0 2m29s
status-list-test-postgresql-0 1/1 Running 0 2m29s
status-list-test-redis-master-0 1/1 Running 0 2m29s
[INFO] Services:
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
status-list-server-local ClusterIP 10.96.44.195 <none> 8081/TCP 2m29s
status-list-test-postgresql ClusterIP 10.96.130.143 <none> 5432/TCP 2m29s
status-list-test-postgresql-hl ClusterIP None <none> 5432/TCP 2m29s
status-list-test-redis-headless ClusterIP None <none> 6379/TCP 2m29s
status-list-test-redis-master ClusterIP 10.96.29.40 <none> 6379/TCP 2m29s
status-list-test-redis-replicas ClusterIP 10.96.215.156 <none> 6379/TCP 2m29s
[INFO] Deployments:
NAME READY UP-TO-DATE AVAILABLE AGE
status-list-server-local 1/1 1 1 2m29s
Now this is handled:
### Service Discovery
All services now use consistent naming:
- **Deployment**: `status-list-server-local`
- **Service**: `status-list-server-local`
helm/status-list-server-chart-local/k8s-deployment-review-feedback.md
Outdated
Show resolved
Hide resolved
helm/status-list-server-chart-local/k8s-deployment-review-feedback.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #103