Add support for credential_response_encryption in credential request#53
Closed
Ogenbertrand wants to merge 12 commits intomainfrom
Closed
Add support for credential_response_encryption in credential request#53Ogenbertrand wants to merge 12 commits intomainfrom
Ogenbertrand wants to merge 12 commits intomainfrom
Conversation
Ogenbertrand
requested review from
IngridPuppet,
forkimenjeckayang and
stephane-segning
Collaborator
Author
|
Ready to be reviewed. |
IngridPuppet
requested changes
Jun 19, 2025
Collaborator
IngridPuppet
left a comment
IngridPuppet
left a comment
There was a problem hiding this comment.
I added a few comments. Please could you check?
forkimenjeckayang
requested changes
Jun 19, 2025
Collaborator
forkimenjeckayang
left a comment
forkimenjeckayang
left a comment
There was a problem hiding this comment.
Left a few comments for you to check out
stephane-segning
requested changes
Jun 19, 2025
Collaborator
stephane-segning
left a comment
stephane-segning
left a comment
There was a problem hiding this comment.
Nothing much relevant to add to what the other said. Keep these points in mind:
- Strict input validation for all encryption parameters – no socks with sandals allowed.
- Encryption must be clearly configurable and documented, simple enough for everyone to understand and use.
- Log debugging info responsibly; sensitive data (keys, credentials) results in can be skipped or strip (like
se***)
Ogenbertrand
requested review from
IngridPuppet,
forkimenjeckayang and
stephane-segning
2 tasks
forkimenjeckayang
requested changes
Jun 26, 2025
Collaborator
forkimenjeckayang
left a comment
forkimenjeckayang
left a comment
There was a problem hiding this comment.
Left a few minor comments for you to revisit. Please check
forkimenjeckayang
approved these changes
Jun 26, 2025
stephane-segning
requested changes
Jun 30, 2025
Collaborator
stephane-segning
left a comment
stephane-segning
left a comment
There was a problem hiding this comment.
Good work. one last change please:
IngridPuppet
reviewed
Jul 7, 2025
Collaborator
IngridPuppet
left a comment
IngridPuppet
left a comment
There was a problem hiding this comment.
I acknowledge a great progress. Just a few more comments. Please, could you check?
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
Ogenbertrand
force-pushed
the
issue-#39310
branch
from
0fc1938 to
1c0a916
Compare
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
Ogenbertrand
force-pushed
the
issue-#39310
branch
from
3ca2994 to
039650e
Compare
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
… b4 defaulting to enc keys Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
IngridPuppet
force-pushed
the
main
branch
2 times, most recently
from
bda0e2a to
f99c912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at supporting credential_response_encryption during the issuing of credentials request. If the Client requested an encrypted response by including the credential_response_encryption object in the request, the Credential Issuer MUST encode the information in the Credential Response as a JWT using the parameters from the credential_response_encryption object. If the Credential Response is encrypted, the media type of the response MUST be set to application/jwt. If encryption was requested in the Credential Request and the Credential Response is not encrypted, the Client SHOULD reject the Credential Response.
See: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#name-credential-request