Add notification_id generation to OID4VCIssuerEndpoint with dedicated… #49
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngridPuppet
reviewed
Jun 2, 2025
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerEndpoint.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCJWTIssuerEndpointTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCJWTIssuerEndpointTest.java
Outdated
Show resolved
Hide resolved
IngridPuppet
approved these changes
Jun 2, 2025
forkimenjeckayang
approved these changes
Jun 2, 2025
… generateNotificationId method and test Signed-off-by: Ogenbertrand <[email protected]>
Signed-off-by: Ogenbertrand <[email protected]>
Signed-off-by: Ogenbertrand <[email protected]>
Signed-off-by: Ogenbertrand <[email protected]>
Signed-off-by: Ogenbertrand <[email protected]>
Signed-off-by: Ogenbertrand <[email protected]>
IngridPuppet
force-pushed
the
main
branch
2 times, most recently
from
bda0e2a to
f99c912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket aims at returning a notification_id in credential responses to support issuance flows that can contain more than one credential, see the spec: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-15.html#name-notification-endpoint.