Intergration env support #283
Open
+5,491
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 245-integration-environment-for-didcomm-mediator-server-deployment-e6
…into 245-integration-environment-for-didcomm-mediator-server-deployment-e6
…/didcomm-mediator-rs into intergration-env-support
Hermann-Core
requested changes
Jan 9, 2025
.debug/.rustc_info.json
Outdated
There was a problem hiding this comment.
remove this folder and the containing file. We don't need it.
chendiblessing
approved these changes
Jan 21, 2025
…/didcomm-mediator-rs into intergration-env-support
…into intergration-env-support
stephane-segning
requested changes
Jan 27, 2025
There was a problem hiding this comment.
This deployment lacks of a volume for the storage dir.
There was a problem hiding this comment.
Please use https://artifacthub.io/packages/helm/bitnami/mongodb instead of rewriting the mongo deployment files.
There was a problem hiding this comment.
Why is this secret meant for?
There was a problem hiding this comment.
If it's for mongo, please use variables instead. This shouldn't be in clear text here like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the architecture followed for the mediator delployment: current implementation can be found on page2 here