Fetch jars and shas from same location #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves adoptium/aqa-tests#5427 |
|
run tests |
karianna
approved these changes
Jul 12, 2024
|
PR needs some sample Grinders run |
llxia
previously requested changes
Jul 17, 2024
llxia
reviewed
Aug 16, 2024
|
@adamfarley Are there any updates on this PR? |
Hi Lan. Thanks for waiting. 🙂 I've included your requested change into the code, and I'm testing now. Link. |
|
Thanks @adamfarley |
adamfarley
force-pushed
the
find_third_party_jars_at_custom_url
branch
from
c866ba2
to
e87ecf4
Compare
If we are getting our third party dependent shas from a custom URL, then the jars should also come from the same location. Signed-off-by: Adam Farley <[email protected]>
adamfarley
force-pushed
the
find_third_party_jars_at_custom_url
branch
from
d36316c
to
0dfa1e7
Compare
|
Updated my code, resolved a merge conflict, and tested the change with a custom aqa-tests branch that cleans up the dependencies before trying to redownload them. Ready for reviews and merge. 🙂 |
andrew-m-leonard
dismissed
llxia’s stale review
Resolved by Adam as per #581 (comment)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are getting our third party dependent shas from a custom URL, then the jars should also come from the same location.
Resolves adoptium/aqa-tests#5427