Fixed snapshot behavior with nested keys #27
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@snewcomer I would need some help/advice how to update
restore()
method.In v2 branch of ember-changeset,
_changes
object was stored as a map/hash with keys in formatfoo
orfoo.bar.baz
.validated-changeset stores
_changes
in format likeBecause of that changes I'm not sure what would you consider the most efficient way of restoring Changeset from snapshot.
The new test
#restore restores a snapshot of the changeset with nested values
has been created and it currently fails as no changes torestore()
have been made.