Fix getBorderSpacing util function for chrome 138.0.7204.169 #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinojv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix: Reordering issue in Chrome v138.0.7204.169
This PR fixes a bug where reordering functionality fails in Chrome version 138.0.7204.169 and above.
📝 Details
Starting with Chrome v138.0.7204.169, the getComputedStyle(el).borderSpacing property now returns a shorthand value (e.g., "0px") instead of separate horizontal and vertical values. This change causes the reordering logic to fail, as it was previously expecting a specific vertical spacing value.
🛠️ Solution
To fix this, a default value has been added for the vertical spacing when the getComputedStyle property returns a shorthand value. This ensures the reordering logic can correctly calculate the element positions, restoring the functionality in the affected Chrome versions.