Fix error TypeError: items[0] is undefined in sortable-item modifier
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-sortable canceled.
|
mkszepp
changed the title
TypeError: items[0] is undefinedTypeError: items[0] is undefined in sortable-itemmodifier
mkszepp
changed the title
TypeError: items[0] is undefined in sortable-itemmodifierTypeError: items[0] is undefined in sortable-item modifier
NullVoxPopuli
approved these changes
Jul 31, 2024
|
@NullVoxPopuli its possible but i think the better way should be to move the addon to TS, so the errors are already visibile while developing :) i'm sure that we find also other errors like this |
|
@NullVoxPopuli test added |
NullVoxPopuli
approved these changes
Aug 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our app we have seen that when we have only one item we are running into error
TypeError: items[0] is undefinedthis is caused, because thefilterreturns possible a empty arrayThe bug was introduced by adding direction
grid#560Workaround in our app (since this bugfix landes) is to add
disabledon group