Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

percy: only lock in the dummy app on the catalog route. #1297

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
test:
name: "Tests"
runs-on: ubuntu-latest
timeout-minutes: 10
env:
PERCY_TOKEN: web_fd6630a88fbe17df0319f50cf1ff005ba127bfea4c61fdd535c69275a648ec28

steps:
- uses: actions/checkout@v4
Expand All @@ -29,11 +32,12 @@ jobs:
- name: Lint
run: pnpm run lint
- name: Run Tests
run: pnpm run test:ember
run: pnpm percy exec -- pnpm run test:ember

floating:
name: "Floating Dependencies"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
Expand All @@ -50,6 +54,7 @@ jobs:
try-scenarios:
name: ${{ matrix.try-scenario }}
runs-on: ubuntu-latest
timeout-minutes: 10
needs: "test"

strategy:
Expand All @@ -76,6 +81,7 @@ jobs:
failing-try-scenarios:
name: ${{ matrix.try-scenario }} Allowed to fail
runs-on: ubuntu-latest
timeout-minutes: 10
needs: "test"

permissions:
Expand Down
2 changes: 1 addition & 1 deletion addon/components/paper-backdrop.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
style={{if @fixed 'position:fixed;'}}
...attributes>
{{yield}}
</md-backdrop>
</md-backdrop>
5 changes: 1 addition & 4 deletions addon/components/paper-sidenav-container.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
/* eslint-disable ember/no-classic-components, ember/require-tagless-components, prettier/prettier */
/* eslint-disable ember/no-classic-components, ember/require-tagless-components */
/**
* @module ember-paper
*/
import Component from '@ember/component';

import { htmlSafe } from '@ember/template';

/**
* @class PaperSidenavContainer
* @extends Ember.Component
*/
export default Component.extend({
classNames: ['flex', 'layout-row'],
attributeBindings: ['style'],
style: htmlSafe('overflow: hidden')
});
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,13 @@
"@ember/jquery": "^1.1.0",
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.4.2",
"@embroider/macros": "^1.16.9",
"@embroider/test-setup": "^0.43.5",
"@faker-js/faker": "^9.0.3",
"@glimmer/component": "^1.0.4",
"@glimmer/tracking": "^1.0.4",
"@percy/cli": "^1.30.1",
"@percy/ember": "^4.2.0",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-cli": "~3.28.4",
Expand Down
Loading
Loading