ci: adds no deprecations workflow #1290
Conversation
✅ Deploy Preview for ember-paper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewhartstonge
force-pushed
the
ci/adds-no-deprecations-workflow
branch
from
5aa21b0
to
0882cc1
Compare
matthewhartstonge
force-pushed
the
ci/adds-no-deprecations-workflow
branch
3 times, most recently
from
2d7cf79
to
0882cc1
Compare
| @@ -80,6 +80,14 @@ module.exports = async function () { | |||
| }, | |||
| embroiderSafe(), | |||
| embroiderOptimized(), | |||
| { | |||
| name: 'no-deprecations', | |||
There was a problem hiding this comment.
so this should be added to the github action workflow (probably in the allowed to fail section 😂) so we actually run it with CI
Also I tend to also add an ember-release-no-deprecations one too that lets us know if we're getting new deprecations that we would need to deal with https://github.com/mansona/ember-cli-notifications/blob/main/test-app/config/ember-try.js#L133-L141 but that's probably getting ahead of ourselves 🙈
There was a problem hiding this comment.
Have added 👍
|
Some tests with 'continue-on-error: true' have failed:
|
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
TSIA!
Removes deprecations from the dummy app where it was directly accessing the application controller router: