Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove no-implicit-this lint errors #1285

Merged
merged 31 commits into from
Oct 23, 2024
Merged

chore: remove no-implicit-this lint errors #1285

merged 31 commits into from
Oct 23, 2024

Conversation

matthewhartstonge
Copy link
Contributor

@matthewhartstonge matthewhartstonge commented Oct 23, 2024 •
edited by mansona
Loading

image

🎉

Fixes #1286

@matthewhartstonge
fix(addon/components/paper-button): remove no-implicit-this.
07758ce
@matthewhartstonge
fix(addon/components/paper-card-media): remove no-implicit-this.
9234fa7
@matthewhartstonge
fix(addon/components/paper-card-title-media): remove no-implicit-this.
8dbdd8b
@matthewhartstonge
fix(addon/components/paper-checkbox): remove no-implicit-this.
f17ca15
@matthewhartstonge
fix(addon/components/paper-contact-chips): remove no-implicit-this.
2e918b9
@matthewhartstonge
fix(addon/components/paper-dialog): remove no-implicit-this.
eaeba73
@matthewhartstonge
fix(addon/components/paper-form): remove no-implicit-this.
bc735d4
@matthewhartstonge
fix(addon/components/paper-icon): remove no-implicit-this.
041f0a7
@matthewhartstonge
fix(addon/components/paper-input): currentLength was not defined, the…
f6fc417 
…refore never yielded correctly in the returned hash.
@matthewhartstonge
fix(addon/components/paper-input): remove no-implicit-this.
431efc0
@matthewhartstonge
fix(addon/components/paper-item): remove no-implicit-this.
cb920e5
@matthewhartstonge
fix(addon/components/paper-optgroup): remove no-implicit-this.
7acdf7d
@matthewhartstonge
fix(addon/components/paper-radio-base): remove no-implicit-this.
d856cc4
@matthewhartstonge
fix(addon/components/paper-radio-group-label): remove no-implicit-this.
e636dcb
@matthewhartstonge
fix(addon/components/paper-radio-group): remove no-implicit-this.
3aad884
@matthewhartstonge
fix(addon/components/paper-progress-circular): remove no-implicit-this.
11c23bf
@matthewhartstonge
fix(addon/components/paper-progress-linear): remove no-implicit-this.
7b180f1
@matthewhartstonge
fix(addon/components/paper-sidenav): remove no-implicit-this.
a7f77dd
@matthewhartstonge
fix(addon/components/paper-sidenav-toggle): remove no-implicit-this.
cb52a34
@matthewhartstonge
fix(addon/components/paper-speed-dial-actions): remove no-implicit-this.
98cfd75
@matthewhartstonge
fix(addon/components/paper-switch): remove no-implicit-this.
3f44b05
@matthewhartstonge
fix(addon/components/paper-tab): remove no-implicit-this.
03aece8
@matthewhartstonge
fix(addon/components/paper-tabs): remove no-implicit-this.
416b6ef
@matthewhartstonge
fix(addon/components/paper-toast): remove no-implicit-this.
62f3b8a
@matthewhartstonge
fix(addon/components/paper-input): validationErrorMessages are includ…
238a8b2 
…ed via the ValidationMixin.
@matthewhartstonge
fix(addon/components/paper-radio-group): toggle and disabled are prov…
b139987 
…ided via the FocusableMixin.
@matthewhartstonge
fix(addon/components/paper-input): disabled is provided via the Focus…
35bc26f 
…ableMixin.
@matthewhartstonge
fix(addon/components/paper-toaster): remove no-implicit-this.
059d832
@matthewhartstonge
fix(addon/components/paper-tooltip): remove no-implicit-this.
394ef5d
@matthewhartstonge
fix(dummy/app/templates/components/doc-content): remove no-implicit-t…
80ea595 
…his.
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for ember-paper ready!

Name Link
🔨 Latest commit 1328c7c
🔍 Latest deploy log https://app.netlify.com/sites/ember-paper/deploys/67187a85256c8500082f8b2f
😎 Deploy Preview https://deploy-preview-1285--ember-paper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

Some tests with 'continue-on-error: true' have failed:

@mansona mansona merged commit f010099 into main Oct 23, 2024
13 checks passed
@mansona mansona deleted the chore/remove-no-implicit-this branch October 23, 2024 10:20
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona Awaiting requested review from mansona

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-implicit-this deprecation
2 participants
@matthewhartstonge @mansona