fix(addon/components/paper-button): fixes on click event bubbling.

adopted-ember-addons · Nov 13, 2024 · bfd8cc0 · bfd8cc0
1 parent df5f109
commit bfd8cc0
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/addon/components/paper-button.js b/addon/components/paper-button.js
@@ -101,17 +101,19 @@ export default class PaperButton extends Focusable {
     return this.args.fab || this.args.mini;
   }
 
+  get bubbles() {
+    return this.args.bubbles === undefined || this.args.bubbles;
+  }
+
   @action handleClick(e) {
     if (this.args.onClick) {
       this.args.onClick(e);
     }
 
     // Prevent bubbling, if specified. If undefined, the event will bubble.
-    if (this.args.bubbles === undefined) {
-      return true;
+    if (!this.bubbles) {
+      e.stopPropagation();
     }
-
-    return this.args.bubbles;
   }
 
   // Proxiable Handlers