Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cookbook): add sample for externally provided model #527

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

RedTn
Copy link
Contributor

@RedTn RedTn commented Dec 17, 2017

Closes #450

table: null,
rows: A([]),

didReceiveAttrs: diffAttrs('model', function(changedAttrs, ...args) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth switching to ember-did-change-attrs at some point but didn't now since it's still a WIP.

@buschtoens buschtoens self-assigned this Dec 19, 2017
@cristinawithout
Copy link

I don't think you want this example to set rows: A([]) on the table component.

It's likely people will want to reuse the component they create with an external data source in more than one place across their application. Setting it this way will make rows shared across all instances of the table. (So when rows change in one table, it will change in every table.) Should probably set the value somewhere like init().

@RedTn
Copy link
Contributor Author

RedTn commented Oct 1, 2018

@buschtoens
Is this still good to be merged once I fix the merge conflicts? The comment from @cristinawithout has already been addressed in the commits I can't resolve the comment on the ui :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants