Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept an array as valuePath #458

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

buschtoens
Copy link
Collaborator

Fixes #456.

@buschtoens
Copy link
Collaborator Author

Compared to the rest of light-table the performance hit introduced by using {{collect}} isn't extreme. Looking at the render performance view in the Ember Dev Tools, I see no noticeable increase in render time for the demo page.

Still, I would like to have some proper metrics first.

@danilovaz
Copy link

Hi @buschtoens ! Anything with this PR? There is something I can help? The addon is amazing and this feature will help a lot

@buschtoens
Copy link
Collaborator Author

buschtoens commented Feb 19, 2018

@danilovaz glad you're loving it ♥️

I'm hesitant to merge, this adds another dependency and slight performance hit for many users, even though they might never use the feature.

However, we got you covered. 😉
https://github.com/buschtoens/ember-light-table-cell-type-multi-value

But please be aware of the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants