Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ember/test-helpers v4 as peerDependency #1076

Merged

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Sep 9, 2024

@ember/test-helpers was recently updated to a v2 addon. Atm we are getting in our app peerDependency warnings of this addon, because it doesn't allow @ember/test-helpers v4.

Copy link
Collaborator

@gilest gilest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you

@gilest gilest merged commit 2fb53a5 into adopted-ember-addons:master Sep 15, 2024
14 checks passed
@mkszepp mkszepp deleted the allow-ember-test-helper-v4 branch September 15, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants