Replace require with importSync to play nice with Embroider
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achambers
changed the title
require with importSync to play nice with Embroider
achambers
force-pushed
the
ac/feature/make-embroider-friendly
branch
from
a27d7f8
to
55365ce
Compare
mansona
approved these changes
Nov 13, 2023
achambers
force-pushed
the
ac/feature/make-embroider-friendly
branch
2 times, most recently
from
71ef079
to
96c2771
Compare
achambers
force-pushed
the
ac/feature/make-embroider-friendly
branch
from
96c2771
to
481aa6a
Compare
patocallaghan
merged commit 965d76d
into
adopted-ember-addons:master
7 of 10 checks passed
patocallaghan
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Add ember-data-model-fragments as an optional peer depdendency * Introduce @embroider/macros * Replace require with importSync to make it Embroider friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
requireas a means of deciding whether to import a package or not and replaces with the the @embroider/macros provideddependencySatisfiesandimportSync. These functions are backwards compatible and therefore will work in both Classic and Embroider builds.