[BREAKING] Replace polyfill assign with Object.assign #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drouhard it looks like you have a bunch of conflicting files. Any chance you could resolve those please? |
Removes deprecated code. See ember-polyfills.deprecate-assign at https://deprecations.emberjs.com/v4.x and adopted-ember-addons#479 for more context. NOTE that Object.assign is not available in IE11, so this commit removes some IE11 support.
drouhard
force-pushed
the
remove-ember-assign-polyfill
branch
from
41cb912
to
8a8c682
Compare
|
@patocallaghan Oops, sorry about the hassle. My personal fork was quite a bit behind this repo. Good to go now 👍 |
|
Thanks @drouhard. Appreciate the contribution 🙌 |
patocallaghan
changed the title
|
FYI @drouhard I released an alpha release with this change in v4.0.0-alpha.1. |
|
Woo hoo! Thanks for the heads up @patocallaghan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Address deprecation warnings. (See https://github.com/emberjs/rfcs/blob/master/text/0750-deprecate-ember-assign.md)
Fix #479
Part of the quest towards a v4 release: #444
Summary
Replaces
assignfrom@ember/polyfillswith javascript built-inObject.assign.NOTE that Object.assign is not available in IE11, so this commit removes some IE11 support.