refactor: octane dummy app files #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techn1x
changed the title
Techn1x
commented
Dec 3, 2022
Comment on lines
-8
to
-13
| setupController(controller, users) { | ||
| let { meta = {} } = users; | ||
| controller.set('model', users); | ||
| controller.set('previousPage', meta.previous); | ||
| controller.set('nextPage', meta.next); | ||
| }, |
There was a problem hiding this comment.
One change I've made that should be functionally the same - I've created a controller for this route and moved the previous/next properties there.
Techn1x
commented
Dec 3, 2022
Comment on lines
17
to
+20
| keyForAttribute() { | ||
| return this._super(...arguments); | ||
| }, | ||
| }); | ||
| return super.keyForAttribute(...arguments); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure why keyForAttribute is defined here when it just calls its super, but I've left it alone in case it's there for a reason (I'm not super familiar with the EmbeddedRecordsMixin)
Techn1x
commented
Dec 3, 2022
| export default JSONAPIAdapter.extend(AdapterFetch); | ||
| export default class extends JSONAPIAdapter.extend(AdapterFetch) {} |
There was a problem hiding this comment.
This will conflict with the removal of AdapterFetch
#464
But whoever merges last can handle the conflct
|
Let me know if there's anything I can help you with |
|
Thanks @Techn1x. Will review later tonight 🙌 |
patocallaghan
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to help out with the ember v4 work where I can #444
classic syntax -> native class
curly brackets -> angle brackets