Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ember 3.28 #448

Merged

Conversation

patocallaghan
Copy link
Collaborator

@patocallaghan patocallaghan commented Sep 27, 2021

Part of #444

Run npx ember-cli-update to upgrade the addon to Ember 3.28. Besides all the regular changes i.e. packages, config changes etc I did the following:

  • Fixed up some new QUnit lint errors
  • Moved tests/dummy/config/scenarios.js into tests/dummy/app/config/scenarios.js to prevent some ESLint issues
  • Allow ember-beta and ember-canary scenarios to fail. Removing the embroider scenarios completely until we can resolve the support in Factory Guy incompatible with Embroider #437

@patocallaghan patocallaghan marked this pull request as ready for review September 27, 2021 15:21
@patocallaghan
Copy link
Collaborator Author

ember-beta and ember-canary scenarios are currently failing with with some Ember global related changes. There's a chunk to unpack there so I'm not going to do it right now

not ok 1 Chrome 93.0 - [undefined ms] - Global error: Uncaught ReferenceError: Ember is not defined at http://localhost:7357/assets/vendor.js, line 68047
    ---
        browser log: |
            {"type":"error","text":"Uncaught ReferenceError: Ember is not defined at http://localhost:7357/assets/vendor.js, line 68047\n","testContext":{}}
WARNING: [DEPRECATION] [DEPRECATION] Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead.

See deprecations.emberjs.com/v3.x/#toc_ember-global for details.

Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help:

* Upgrade the following addons to the latest version:
  * active-model-adapter
  * ember-data-model-fragments
  * ember-data
  * ember-django-adapter

### Important ###

In order to avoid repeatedly showing the same deprecation messages, no further deprecation messages will be shown for usages of the Ember Global until ember-cli-babel is upgraded to v7.26.6 or above.

To see all instances of this deprecation message, set the `EMBER_GLOBAL_DEPRECATIONS` environment variable to "all", e.g. `EMBER_GLOBAL_DEPRECATIONS=all ember test`.

### Details ###

Prior to v7.26.6, ember-cli-babel sometimes transpiled imports into the equivalent Ember Global API, potentially triggering this deprecation message indirectly, even when you did not observe these deprecated usages in your code.

The following outdated versions are found in your project:

* [email protected], currently used by:
  * @ember/[email protected]
    * Depends on ember-cli-babel@^6.16.0
    * Added by [email protected]
  * [email protected]
    * Depends on ember-cli-babel@^6.8.2
  * [email protected]
    * Depends on ember-cli-babel@^6.6.0
    * Added by [email protected]
  * [email protected]
    * Depends on ember-cli-babel@^6.8.0
  * [email protected]
    * Depends on ember-cli-babel@^6.16.0
  * [email protected]
    * Depends on ember-cli-babel@^6.0.0
    * Added by [email protected]
    * Added by [email protected]
  * [email protected]
    * Depends on ember-cli-babel@^6.6.0
    * Added by [email protected]
  * [email protected] (Dormant)
    * Depends on ember-cli-babel@^6.0.0-beta.4

Note: Addons marked as "Dormant" does not appear to have any JavaScript files. Therefore, even if they are using an old version ember-cli-babel, they are unlikely to be the culprit of this deprecation and can likely be ignored.

Copy link

@22a 22a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@patocallaghan patocallaghan merged commit 4667af1 into adopted-ember-addons:master Sep 27, 2021
@patocallaghan patocallaghan deleted the patoc/ember-li-3.28 branch September 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants