-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ember 3.28 #448
Merged
patocallaghan
merged 2 commits into
adopted-ember-addons:master
from
patocallaghan:patoc/ember-li-3.28
Sep 27, 2021
Merged
Upgrade to Ember 3.28 #448
patocallaghan
merged 2 commits into
adopted-ember-addons:master
from
patocallaghan:patoc/ember-li-3.28
Sep 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patocallaghan
force-pushed
the
patoc/ember-li-3.28
branch
from
September 27, 2021 15:05
0ddf0aa
to
861a359
Compare
|
achambers
approved these changes
Sep 27, 2021
22a
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #444
Run
npx ember-cli-update
to upgrade the addon to Ember 3.28. Besides all the regular changes i.e. packages, config changes etc I did the following:tests/dummy/config/scenarios.js
intotests/dummy/app/config/scenarios.js
to prevent some ESLint issuesember-beta
andember-canary
scenarios to fail. Removing the embroider scenarios completely until we can resolve the support in Factory Guy incompatible with Embroider #437