always use extend for Internal OptionsObject

adopted-ember-addons · Nov 9, 2023 · e72c267 · e72c267
1 parent 75d558c
commit e72c267
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/addon/-private/options.js b/addon/-private/options.js
@@ -18,11 +18,7 @@ export default class Options {
     const optionKeys = keys(options);
     const createParams = { [OPTION_KEYS]: optionKeys, model, attribute };
 
-    // If any of the options is a CP, we need to create a custom class for it
-    if (optionKeys.some((key) => isDescriptor(options[key]))) {
-      return OptionsObject.extend(options).create(createParams);
-    }
-
-    return OptionsObject.create(createParams, options);
+    // we have to extend here in case anyone passes options that have computedProperties.
+    return OptionsObject.extend(options).create(createParams);
   }
 }