WIP - Hack to preserve cell order #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raytiley .. any word on when this might get merged? me like having dom elements in same order as list |
|
@raytiley : We tried the hack and it is not working in our case, the collection is still being rendered in random order. |
|
Has anyone ever been able to successfully keep the DOM elements in the same order as the list? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spike to fix issues #97, and #72.
Would like to get feedback from @krisselden and or @stefanpenner about the approach.
Basically should we go through extra logic to keep the
_cellsarray stable and just rearrange the items in it, or can we just build a new array and replace_cells.Once an approach is decided on I can work on a more complete implementation and tests.